Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SoftDeleted repository and change Directions #1201

Merged
merged 9 commits into from
Aug 28, 2023
Merged

Add SoftDeleted repository and change Directions #1201

merged 9 commits into from
Aug 28, 2023

Conversation

alrom
Copy link
Contributor

@alrom alrom commented Aug 18, 2023

No description provided.

@alrom alrom added the backend Issue involves backend functionality label Aug 18, 2023
@alrom alrom requested review from h4wk13, DmyMi, VadymLevkovskyi and a team August 18, 2023 17:32
@alrom alrom self-assigned this Aug 18, 2023
VadymLevkovskyi
VadymLevkovskyi approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@VadymLevkovskyi VadymLevkovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See no issues with logic. Have few comments (that might be ignored) about code style/design

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
3.0% 3.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@DmyMi DmyMi merged commit 2a67746 into develop Aug 28, 2023
@DmyMi DmyMi deleted the Romanchuk/AddSoftDeletedRepository branch August 28, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadymLevkovskyi VadymLevkovskyi VadymLevkovskyi approved these changes

@h4wk13 h4wk13 Awaiting requested review from h4wk13

@DmyMi DmyMi Awaiting requested review from DmyMi

Assignees

@alrom alrom

Labels
backend Issue involves backend functionality
Projects
OoS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alrom @VadymLevkovskyi @DmyMi